Skip to content

Correct description of the cluster field in RestorePlan#17480

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
apratimutkarsh:fix-gkebackup-description
May 8, 2026
Merged

Correct description of the cluster field in RestorePlan#17480
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
apratimutkarsh:fix-gkebackup-description

Conversation

@apratimutkarsh
Copy link
Copy Markdown
Contributor

@apratimutkarsh apratimutkarsh commented May 8, 2026

Description

To avoid confusion from treating the "source cluster" as the backup cluster, this PR updates the cluster field description in the RestorePlan configuration.

This change aligns the description with the error message on docs.cloud.google.com, which clarifies it as: "the name of the target cluster to which you want to restore the backup".

References

Fixes b/509846441

Release Note Template for Downstream PRs

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 8, 2026
@github-actions github-actions Bot requested a review from melinath May 8, 2026 15:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@apratimutkarsh
Copy link
Copy Markdown
Contributor Author

Ccing @avijitagarwal195 who previously reviewed the internal version of this change.

@modular-magician modular-magician added service/gkebackup and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 8, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2e8f858:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 2 insertions(+), 2 deletions(-)
google-beta provider View Diff 2 files changed, 2 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
29 29 0 0
Affected Service Packages
  • gkebackup

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@apratimutkarsh VCR tests complete for 2e8f858!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants