Migrated Compute router status to use transport_tpg.SendRequest

[jcromanu]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_router_status` data source to use direct HTTP rather than a client library

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1407
Passed tests: 1314
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceComputeRouterStatus [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 46 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 46 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1417
Passed tests: 1311
Skipped tests: 91
Affected tests: 15

Click here to see the affected service packages

• compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample
• TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample
• TestAccComputeFirewallPolicyRule_secureTags
• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update
• TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample
• TestAccComputeNetworkFirewallPolicyRule_secureTags
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicyWithRules_update
• TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample
• TestAccComputeRegionNetworkFirewallPolicyRule_secureTags
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1421
Passed tests: 1328
Skipped tests: 91
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceComputeRouterStatus [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 128510e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 42 insertions(+), 24 deletions(-)
google-beta provider	View Diff	1 file changed, 42 insertions(+), 24 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1422	1330	91	1

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceComputeRouterStatus

View the build log

---

Step 2: Recording Mode

Test Name	Recording Mode	Replaying Rerun
TestAccDataSourceComputeRouterStatus	🔴 Failed [Error message] [Debug log]	-

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcromanu VCR tests complete for 128510e!

[slevenick]

Looks like the tests aren't passing, please fix

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4ddedda:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 45 insertions(+), 24 deletions(-)
google-beta provider	View Diff	1 file changed, 45 insertions(+), 24 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1427	1336	91	0

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@jcromanu VCR tests complete for 4ddedda!

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

Thanks!