add Forward_proxy to compute.backendService DynamicForwarding#16665
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
dynamic_forwarding {
forward_proxy {
enabled = # value needed
proxy_mode = # value needed
}
}
}
|
1ccf00f to
6e7d8e6
Compare
This feature is not enabled for global yet, but the API is already available. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
dynamic_forwarding {
forward_proxy {
enabled = # value needed
proxy_mode = # value needed
}
}
}
|
Tests analyticsTotal tests: 1384 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Tests analyticsTotal tests: 1384 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
6e7d8e6 to
9aa28aa
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
dynamic_forwarding {
forward_proxy {
enabled = # value needed
proxy_mode = # value needed
}
}
}
|
Tests analyticsTotal tests: 1384 Click here to see the affected service packages
🟢 All tests passed! View the build log |
9aa28aa to
39e47a2
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
dynamic_forwarding {
forward_proxy {
enabled = # value needed
proxy_mode = # value needed
}
}
}
|
Tests analyticsTotal tests: 1384 Click here to see the affected service packages
🟢 All tests passed! View the build log |
39e47a2 to
3a6c136
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1386 Click here to see the affected service packages
🟢 All tests passed! View the build log |
07aa40d
Added ForwardProxy to RegionBackendService DynamicForwarding.
Also added missing INTERNAL_SELF_MANAGED loadBalancingScheme to RegionBackendService to allow testing.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.