Skip to content

add Forward_proxy to compute.backendService DynamicForwarding#16665

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
pawelJas:add-backend-service-dynamic-forwarding-beta
Mar 13, 2026
Merged

add Forward_proxy to compute.backendService DynamicForwarding#16665
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
pawelJas:add-backend-service-dynamic-forwarding-beta

Conversation

@pawelJas
Copy link
Copy Markdown
Contributor

@pawelJas pawelJas commented Mar 10, 2026

Added ForwardProxy to RegionBackendService DynamicForwarding.
Also added missing INTERNAL_SELF_MANAGED loadBalancingScheme to RegionBackendService to allow testing.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `ForwardProxy` field in `google_compute_region_backend_service` resource

@github-actions github-actions Bot requested a review from slevenick March 10, 2026 19:30
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Comment thread mmv1/products/compute/BackendService.yaml Outdated
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 7 files changed, 354 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from 1ccf00f to 6e7d8e6 Compare March 10, 2026 19:54
@github-actions github-actions Bot requested a review from slevenick March 10, 2026 19:55
@pawelJas
Copy link
Copy Markdown
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-)) google-beta provider: Diff ( 7 files changed, 354 insertions(+), 4 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

This feature is not enabled for global yet, but the API is already available.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 84 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 7 files changed, 358 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field dynamic_forwarding.ip_port_selection.enabled changed from optional to required on google_compute_backend_service - reference
  • Field dynamic_forwarding.ip_port_selection.enabled changed from optional to required on google_compute_region_backend_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1292
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyCloudRunExample
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyDirectForwardingExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyCloudRunExample [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyDirectForwardingExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Comment thread mmv1/products/compute/BackendService.yaml Outdated
Comment thread mmv1/products/compute/RegionBackendService.yaml Outdated
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1292
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyCloudRunExample
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyDirectForwardingExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyCloudRunExample [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyDirectForwardingExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@pawelJas pawelJas requested a review from slevenick March 11, 2026 05:38
@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from 6e7d8e6 to 9aa28aa Compare March 11, 2026 17:02
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 7 files changed, 354 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1294
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Comment thread mmv1/products/compute/BackendService.yaml Outdated
Comment thread mmv1/products/compute/BackendService.yaml Outdated
@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from 9aa28aa to 39e47a2 Compare March 11, 2026 18:33
@github-actions github-actions Bot requested a review from slevenick March 11, 2026 18:34
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 7 files changed, 354 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1294
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from 39e47a2 to 3a6c136 Compare March 13, 2026 09:19
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 66 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 245 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1386
Passed tests: 1296
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@slevenick slevenick added this pull request to the merge queue Mar 13, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 07aa40d Mar 13, 2026
23 checks passed
@pawelJas pawelJas deleted the add-backend-service-dynamic-forwarding-beta branch March 14, 2026 04:10
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 16, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants