Skip to content

deletion policy generation netapp-oslogin#16627

Merged
NickElliot merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policyfrom
NickElliot:dpolicygenno
Mar 16, 2026
Merged

deletion policy generation netapp-oslogin#16627
NickElliot merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policyfrom
NickElliot:dpolicygenno

Conversation

@NickElliot
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 274 files changed, 3905 insertions(+))
google-beta provider: Diff ( 290 files changed, 4193 insertions(+))

@NickElliot
Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 274 files changed, 3905 insertions(+))
google-beta provider: Diff ( 290 files changed, 4193 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 372
Passed tests: 352
Skipped tests: 19
Affected tests: 1

Click here to see the affected service packages
  • orgpolicy
  • oslogin
  • netapp
  • networksecurity
  • notebooks
  • observability
  • osconfig
  • osconfigv2
  • networkconnectivity
  • networkconnectivityv1
  • networkmanagement
  • networkservices
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkManagementConnectivityTests_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkManagementConnectivityTests_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 275 files changed, 3907 insertions(+))
google-beta provider: Diff ( 291 files changed, 4195 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 372
Passed tests: 353
Skipped tests: 19
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
  • osconfigv2
  • oslogin
  • networkconnectivity
  • networkservices
  • notebooks
  • orgpolicy
  • osconfig
  • netapp
  • networkconnectivityv1
  • networkmanagement
  • networksecurity
  • observability

🟢 All tests passed!

View the build log

@NickElliot NickElliot marked this pull request as ready for review March 6, 2026 18:42
@NickElliot NickElliot requested a review from c2thorn March 6, 2026 18:42
@NickElliot NickElliot merged commit 161981e into GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policy Mar 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants