Skip to content

Netapp volume documentation correction#13597

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
hyacin75:netapp-volume-docs-correction
Apr 9, 2025
Merged

Netapp volume documentation correction#13597
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
hyacin75:netapp-volume-docs-correction

Conversation

@hyacin75
Copy link
Copy Markdown
Contributor

@hyacin75 hyacin75 commented Apr 9, 2025

Correction to Netapp volume, restore_parameters block documentation.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot requested a review from ScottSuarez April 9, 2025 05:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2025
@ScottSuarez ScottSuarez added this pull request to the merge queue Apr 9, 2025
@modular-magician modular-magician added service/netapp and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 9, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  restore_parameters {
    source_backup = # value needed
  }
}

Merged via the queue into GoogleCloudPlatform:main with commit 0710dad Apr 9, 2025
20 of 23 checks passed
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp

🟢 All tests passed!

View the build log

Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 26, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants