Skip to content

v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used #673

@caugner

Description

@caugner

In 16709c6, @matthewrobertson bumped @types/express from 4.17.21 to ^5.0.0, which probably wasn't intended.

This causes issues, because the RouteParameters type in @types/express-serve-static-core, which is used by @types/express, changed slightly between v4 and v5

This caused unexpected issues for us when upgrading dependencies in https://github.com/mdn/yari/blob/main/cloud-function/package.json, as @sentry/google-cloud-serverless 8.54.0 expects express v4 types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions