fix: explicitly tag and push the latest image#342
Merged
Conversation
| env: | ||
| - CLOUDSDK_CORE_DISABLE_PROMPTS=1 | ||
|
|
||
| images: |
Collaborator
There was a problem hiding this comment.
I don't think we should remove the images field, it helps with build provenance. Let's just add :latest as the image tag here
Collaborator
Author
There was a problem hiding this comment.
This wasn't present before. I had recently added it thinking it was missing.
On deep dive, realized that this was not present because we were explicitly pushing the images in the second step. Because of that, this would be a no-op.
Collaborator
Author
There was a problem hiding this comment.
Also, looks like the images are explicitly pushed because we need to immediately use them for deploying.
ShellyAgg
approved these changes
Apr 20, 2026
HarshaliRaka
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.