Skip to content

Adding apollo.#1

Closed
Gongreg wants to merge 13 commits intomasterfrom
apollo
Closed

Adding apollo.#1
Gongreg wants to merge 13 commits intomasterfrom
apollo

Conversation

@Gongreg
Copy link
Copy Markdown
Owner

@Gongreg Gongreg commented Dec 12, 2018

Functionality needed to support apollo.
The way it works is that one part of apollo dev tools which takes apollo client and uses it is added inside the react native worker. Then everything happens through post messages jus like with apollo dev tools for react.

Currently I just pasted the apollo code, but I think we can use injectScripts to inject necessary part of apoloo dev tools to the worker.

This is just a POC to show that it can work.

This goes together with: https://github.com/Gongreg/apollo-client-devtools/pull/1

@peggyrayzis
Copy link
Copy Markdown

This is incredible!! Thank you so much for your hard work on this @Gongreg 🎉

Once this is merged, would you mind adding a PR to https://www.apollographql.com/docs/react/recipes/react-native.html detailing how to set it up for people unfamiliar with react-native-debugger? Once that's complete, we'll publicize it from the @apollographql Twitter account. I'm sure a ton of RN devs are going to be thrilled to hear about it!

@Gongreg
Copy link
Copy Markdown
Owner Author

Gongreg commented Dec 12, 2018

Hey @peggyrayzis,
I am really glad to hear that you like it :)

I will try to implement a proper solution for React-Native-Debugger as soon as I can (this was one long day of hacking things around, so definitely not production ready code).

I also tried to add it inside the debugger that is published together with react native itself but I couldn't, since to support Apollo dev tools we need to inject some of the Apollo code into worker that runs actual javascript code.

I hope I will be able to bring more good news in the near future.

@peggyrayzis
Copy link
Copy Markdown

Sounds great. Let me know if there's anything our team can do to help! 🚀

cc @hwillson

@Gongreg
Copy link
Copy Markdown
Owner Author

Gongreg commented Jan 14, 2019

Closing this PR since it is in my own fork. Relevant PR:

apollographql/apollo-client-devtools#160
apollographql/apollo-client-devtools#165
jhen0409#298

@Gongreg Gongreg closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants