Fix syntax error in generated GitVersionInformation class when using project namespace#4197
Merged
Conversation
arturcic
approved these changes
Sep 3, 2024
Contributor
|
Thank you @rose-a for your contribution! |
|
@arturcic would this PR merge be sufficient motivation to publish a 6.0.3 to enable the MSBuild from working again with the explicit notice that From the other threads on this issue (#4196 and #4116) the indication and general consensus seemed to be that getting MSBuild to work again would be a TBA/TBD scenario, but if I understand this commit/enhancement correctly, this PR would allow 'us' to use GitVersion 6.x with MSBuild scenarios again as long as the right set of properties are configured. If I misunderstood, then apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4196.
Description
Using a file-scoped namespace declaration is not possible because of the optional declaration of
ExcludeFromCodeCoverageAttributein the same source file, which needs to be declared in theSystem.Diagnostics.CodeAnalysisnamespace.Related Issue
#4196
Motivation and Context
The target namespace declaration is now generated properly
How Has This Been Tested?
Regression test was added to GitVersion.Output.Tests (
GitVersionInfoGeneratorTests.ShouldProperlyOutputNamespaceDeclaration())Screenshots (if appropriate):
Checklist: