Skip to content

Introducing a new templating mechanism to support different workflows#3409

Merged
arturcic merged 6 commits into
GitTools:mainfrom
HHobeck:feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows
Mar 1, 2023
Merged

Introducing a new templating mechanism to support different workflows#3409
arturcic merged 6 commits into
GitTools:mainfrom
HHobeck:feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows

Conversation

@HHobeck

@HHobeck HHobeck commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Introducing a new templating mechanism to support different workflows

Closes #3305

Description

Related Issue

#3305

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread src/GitVersion.Core/Configuration/ConfigurationProvider.cs Outdated
Comment thread src/GitVersion.Core/GitVersion.Core.csproj Outdated
@arturcic

arturcic commented Mar 1, 2023

Copy link
Copy Markdown
Member

Please also rebase on main

@HHobeck HHobeck force-pushed the feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows branch from bc6829d to 1207827 Compare March 1, 2023 07:38

@arturcic arturcic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HHobeck

HHobeck commented Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

I'm just thinking about to add a trunc based workflow to the WorkflowManager. Do you know how the configuration should look like?

https://gitversion.net/docs/learn/branching-strategies/

@arturcic

arturcic commented Mar 1, 2023

Copy link
Copy Markdown
Member

I think @asbjornu can have a better answer to your question

@arturcic

arturcic commented Mar 1, 2023

Copy link
Copy Markdown
Member

@arturcic

arturcic commented Mar 1, 2023

Copy link
Copy Markdown
Member

I think we can merge this one, and later you can have a new PR with the trunk based workflow? Agree?

@arturcic arturcic merged commit 23502ec into GitTools:main Mar 1, 2023
@arturcic arturcic deleted the feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows branch March 1, 2023 09:49
@mergify

mergify Bot commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Thank you @HHobeck for your contribution!

@arturcic

arturcic commented Mar 1, 2023

Copy link
Copy Markdown
Member

@HHobeck please create a PR with the trunk based workflow when you figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Introducing a new templating mechanism to support different workflows

2 participants