pygmt.show_versions: Report GDAL version by calling the GDAL C function#4104
Merged
pygmt.show_versions: Report GDAL version by calling the GDAL C function#4104
Conversation
b873cd4 to
9902f6c
Compare
9902f6c to
b5cfc3d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves GDAL version reporting in PyGMT by querying the GDAL version directly from the GDAL C library using ctypes instead of relying on Python package metadata.
- Adds a new
_get_gdal_version()function that uses ctypes to call the GDAL C API'sGDALVersionInfofunction - Updates the dependency information collection to use the new GDAL version function instead of treating GDAL as a regular Python package
- Adds test assertions to verify that GDAL version is properly reported and not returning None
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pygmt/_show_versions.py | Implements new GDAL version detection using ctypes and updates dependency collection logic |
| pygmt/tests/test_show_versions.py | Adds test coverage to verify GDAL version is correctly reported |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c0584fc to
e548c16
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
e548c16 to
9f5630a
Compare
weiji14
reviewed
Sep 19, 2025
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Query the GDAL version by calling the GDAL C function
GDALVersionInfo(https://gdal.org/en/stable/api/raster_c_api.html#_CPPv415GDALVersionInfoPKc).Fixes #4102.