Figure.logo: Let the 'style' parameter support descriptive arguments

[seisman]

This PR improves the style parameter (i.e., -S option). Previously the style parameter can only accept l/n/u. Now it can accept more descriptive arguments standard/no_label/url.

The upstream GMT uses long names standard/none/url (see https://github.com/GenericMappingTools/gmt/blob/c95470b1c78c412fa15d388be0d9b07de111ba49/src/longopt/gmtlogo_inc.h#L37), but I feel no_label is more descriptive.

Preview: https://pygmt-dev--4074.org.readthedocs.build/en/4074/api/generated/pygmt.Figure.logo.html

[Copilot]

Pull Request Overview

This PR enhances the style parameter in the Figure.logo method to accept more descriptive string arguments instead of single-letter codes. The change improves code readability by allowing "standard", "url", and "no_label" instead of cryptic "l", "u", and "n" values.

• Updated the style parameter to use descriptive literal types with proper type hints
• Implemented alias mapping to convert descriptive names to GMT's single-letter codes
• Updated documentation to reflect the new descriptive parameter values

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[weiji14]

Hmm, I'm getting a 403 when trying to access https://dagshub.com/GenericMappingTools/pygmt, server might be down or something.

[seisman]

Hmm, I'm getting a 403 when trying to access https://dagshub.com/GenericMappingTools/pygmt, server might be down or something.

I can access the website, and I can even run dvc pull successfully using my local computer. So it's more likely CI issues.

[yvonnefroehlich]

Hmm, I'm getting a 403 when trying to access https://dagshub.com/GenericMappingTools/pygmt, server might be down or something.

I can access the website, and I can even run dvc pull successfully using my local computer.

Same for me.

[yvonnefroehlich]

The upstream GMT uses long names standard/none/url (see https://github.com/GenericMappingTools/gmt/blob/c95470b1c78c412fa15d388be0d9b07de111ba49/src/longopt/gmtlogo_inc.h#L37), but I feel no_label is more descriptive.

I prefere no_label. In general, I feel having "none" and None is not optimal.

[seisman]

I tried debugging the DVC issue but wasn't successful. I think we'll have to move on for now and revisit it in the future if a fix becomes available.

[seisman]

Ping @GenericMappingTools/pygmt-maintainers for final reviews. Will merge in 24 hours.

[yvonnefroehlich]

I feel style was introduced to consistently use this alias for -S. But I am wondering if something linke label would be more suitable here.

[seisman]

I feel style was introduced to consistently use this alias for -S.

Yes.

But I am wondering if something linke label would be more suitable here.

label also sounds a good name, but we already have label aliased to the common option -l. Using label here may be a little misleading.

[seisman]

Any more comments on the changes? Plan to merge it in 24 hours.