Store first tile as source encoding for tiled grids#3950
Merged
Conversation
weiji14
commented
May 14, 2025
Comment on lines
595
to
601
| # Full path to the grid | ||
| source: str | list = which(fname, download="a") | ||
| if resinfo.tiled: | ||
| source = sorted(source)[0] # get first grid for tiled grids | ||
| # Manually add source to xarray.DataArray encoding to make the GMT accessors work. | ||
| if source: | ||
| grid.encoding["source"] = source |
Member
Author
There was a problem hiding this comment.
Could add verbose="q" to the which call here, and probably remove the if source: line, but doesn't really matter if it's all gonna go away after the refactor to use xr.load_dataarray in #3932.
Member
There was a problem hiding this comment.
I prefer to have verbose="d" added and if source removed, so that this PR is fully functional on its own.
seisman
reviewed
May 14, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 14, 2025
seisman
approved these changes
May 14, 2025
Member
seisman
left a comment
There was a problem hiding this comment.
Looks good except one minor edit.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Tiled remote dataset grids used to have an undefined
grid.encoding["source"]because there was a list of grids returned frompygmt.which, and we did not select any one. The change here means that we setgrid.encoding["source"]to the first grid in the list (sorted alphabetically).This means that slicing
xarray.DataArraytiled grids should return proper GMT AccessorGridTypeandGridRegistrationvalues, because the source file can be queried usinggrdinfoto get the values.Addresses #3932 (comment) and #524
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code