Move pygmt.show_versions function to _show_versions.py#3277
Merged
Conversation
Shorten some code in the pygmt.show_versions function to fit it under 50 statements.
Extracted _get_clib_info, _get_module_version, _get_ghostscript_version, _check_ghostscript_version functions out of show_versions(). Moved some Python standard library imports to the top-level instead of nesting in the function.
seisman
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Move
pygmt.show_versions()function from__init__.pyto_show_versions.pybecause it got too long after #3244, and ruff v0.4.6 introduced a minor change in astral-sh/ruff#11521 that counts every branch in the match statement as a single statement, causingpygmt.show_versions()to exceed the 50 statement limit.Reference:
Fixes #3276
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code