CI: Remove pytest-xdist and pytest-rerunfailures options from addopts and only add them in CI jobs#3267
Merged
CI: Remove pytest-xdist and pytest-rerunfailures options from addopts and only add them in CI jobs#3267
Conversation
… and only add them in CI jobs
weiji14
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In PR #3193, pytest-xdist and pytest-rerunfailures were added to speed up the CI jobs. They work well but also cause some troubles:
-n auto --reruns 2are added toaddopts, so pytest-xdist and pytest-rerunfailures are required in local environments.pytest-xdist's-n autooption always initializes multiple workers, which takes more time when running a single test.This PR removes the options
-n auto --reruns 2frompyproject.tomland add the options to the workflows if needed.