Figure.plot: Update docstring for "connection" parameter to GMT 6.5#2994
Merged
Figure.plot: Update docstring for "connection" parameter to GMT 6.5#2994
Conversation
This reverts commit 686b4a7.
Member
I also found the same issue in PR #2992. There are three files that use external resources and removing all of them fixes the ReadTheDocs failure (see 70d53af). |
seisman
reviewed
Jan 13, 2024
seisman
reviewed
Jan 14, 2024
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Jan 14, 2024
Member
seisman
left a comment
There was a problem hiding this comment.
Good to merge after add the two examples back.
Member
Author
|
/format |
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Over time, the general syntax for the
connection(F) parameter ofFigure.plothas changed:GMT 6.2
-F[c|n|r][a|f|s|r|refpoint]GMT 6.3
-F[c|n|p][a|f|s|r|refpoint]GMT 6.5
-F[c|n|p][a|r|s|t|refpoint]This PR updates the related docstring in the PyGMT documentation to match the GMT 6.5 documentation. I feel this makes sense, as we link to the last GMT version and we use it in the gallery examples, or?
I am wondering whether the last line of the figure caption in the GMT documentation has to be updated from
"
directives ra, rt, rs, r10/35 and na" to"
directives pa, pt, ps, p10/35 and na"?Preview:
There is currently an issue with buiding the documentation:
Edit 2024/13/01
Excluding the gallery example
chorophleth_map.py(see commit) leads toSo, the issue seem to be unrelated to the
chorophleth_map.pyexample (downloading the data).After removing both
chorophleth_map.pyandroads.pybuilding the documentation is successful.https://pygmt-dev--2994.org.readthedocs.build/en/2994/api/generated/pygmt.Figure.plot.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code