Conversation
michaelgrund
approved these changes
Jan 3, 2024
yvonnefroehlich
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we set both
cache-downloadsandcache-environmentoptions totruein themamba-org/setup-micromambaaction. So, in the "Setup Micromamba" step, we see information like below:Apparently,
cache-downloadscaches/restores the packages in the/home/runner/micromamba/pkgsdirectory andcache-environmentcaches/restores the environment from/home/runner/micromamba/envs/pygmt. The cached packages are NOT used in the following steps, thus caching downloads is unnecessary.This PR changes the
cache-downloadsoption tofalseinci_*.ymlworkflows.Comparing this branch (https://github.com/GenericMappingTools/pygmt/actions/runs/7384789955/job/20088312682?pr=2946) with the main branch (https://github.com/GenericMappingTools/pygmt/actions/runs/7383547780/job/20084932207), the "Setup Micromamba" step is now faster by a few seconds on Linux and 10-100 seconds faster on Windows.