Benchmark grdsample, grdfilter and sph2grd with fixed cores#2945
Merged
Benchmark grdsample, grdfilter and sph2grd with fixed cores#2945
Conversation
CodSpeed Performance ReportMerging #2945 will not alter performanceFalling back to comparing Summary
|
weiji14
commented
Jan 4, 2024
Comment on lines
141
to
143
| fig_ref.grdimage( | ||
| grid="@earth_relief_01d_g", region="GL", cmap="geo", shading=xrgrid | ||
| grid="@earth_relief_01d_g", region="GL", cmap="geo", shading=xrgrid, cores=2 | ||
| ) |
Member
Author
There was a problem hiding this comment.
This line is raising an error at https://github.com/GenericMappingTools/pygmt/actions/runs/7404780202/job/20146784435?pr=2945#step:8:778:
E pygmt.exceptions.GMTCLibError: Module 'grdimage' failed with status code 72:
Error: grdimage [ERROR]: Option -x given more than once
Error: grdimage [ERROR]: Option -x parsing failure. Correct syntax:
Error: grdimage [ERROR]: Offending option -x2
Equivalent GMT CLI command also fails (both on GMT 6.4.0 and GMT 6.5.0.dev9+0776994):
gmt grdimage @earth_relief_01d_g -RGL -Cgeo -x2 -png map
grdimage [ERROR]: Option -x given more than once
grdimage [ERROR]: Option -x parsing failure. Correct syntax:
[-x[[-]<n>]] .
Limit the number of cores used in multi-threaded algorithms [Default uses all 16 cores]. If <n> is negative then we select (16 - <n>) cores (or at least 1).
grdimage [ERROR]: Offending option -x2
Might be an upstream GMT bug?
Member
Author
There was a problem hiding this comment.
Ok, reported upstream at GenericMappingTools/gmt#8256. I've reverted the grdimage commit at 08f36d2 for now.
This reverts commit 56b47f2.
seisman
reviewed
Jan 4, 2024
This reverts commit 56d50be.
seisman
approved these changes
Jan 4, 2024
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Benchmarking OpenMP multi-threaded algorithms with a fixed number of CPU cores, to ensure consistency of benchmarks.
Using a fixed core count of 2, which is the maximum number of CPU cores for GitHub Actions' Linux runners - https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
TODO:
Fixes #2942
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version