Add gallery example to show usage of dcw parameter in Figure.coast#2428
Add gallery example to show usage of dcw parameter in Figure.coast#2428
Conversation
|
/format |
willschlitzer
left a comment
There was a problem hiding this comment.
I know it's not marked ready for review, but here are some changes I thought would be good.
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
|
@michaelgrund Is this ready for review, or are you still working on it? |
Yes it is, thanks for your comments and improvements @willschlitzer. |
|
/format |
|
For unknown reasons, all the inline comments disappear in the built page (https://pygmt-dev--2428.org.readthedocs.build/en/2428/gallery/maps/country_polygons.html). |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Strange, also the title changes are not considered. |
Hm. Did someone change something to fix this? If not, that's really strange, because I face none of these issues. As title of this gallery example I see "Highlight country and continent polygons" (not "Highlight country polygons") and the inline examples are displayed in the API references. |
In my case it depends on the device. On my smartphone everything looks fine, |
Yes, now it looks good. |
Added this use-case. |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
|
/format |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Just one suggestion on the projection for Europe, otherwise ready for final review!
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Added also "state" to the title since now we're showing 3 different use-cases.

Description of proposed changes
This PR adds a gallery example to show the basic usage of the
dcwparameter.Preview: https://pygmt-dev--2428.org.readthedocs.build/en/2428/gallery/maps/country_polygons.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version