Adding API test for plotting a global matrix/grid for different central meridians#3811
Merged
PaulWessel merged 8 commits intomasterfrom Aug 1, 2020
Merged
Adding API test for plotting a global matrix/grid for different central meridians#3811PaulWessel merged 8 commits intomasterfrom
PaulWessel merged 8 commits intomasterfrom
Conversation
Member
Author
|
Just for reference, here is the current output of testapi_matrix_360.c. The top plot should show the Pacific centered on 180.
|
Member
Author
|
Hi @seisman, I'd like to merge this to master even though there is no fix yet (so test will fail since no orig PS). Problem I have is it takes Xcode so long to completely cmake up a new branch, and since this branch adds a new C file I need to wipe and start fresh since otherwise it complains about missing C module (if I switch back/forth with master). So my plan is to put this into master now and then when a fix is found we can merge and backport as well. If there is no problems with this plan then please approve. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2020
…al meridians (#3811) * Explore passing matrix to grdimage for different central longitudes * Update testapi_matrix_360.c * Try rotating the grid * Update testapi_matrix_360.c * Add the test script * Update gmt_api.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See GenericMappingTools/pygmt#515 (comment) for the backstory. This PR adds a new testapi_matrix_360.c test program in C that recreates the same type of problem. The plot with a zero central meridian looks fine but the one for 180 is not rotated to show the Pacific and has a nasty notch at Greenwhich instead. I will try to make this case work once I better understand the reason. Initial attempts to rotate the grid failed, so there is more to it.