Eliminate 1000ms ETW latency (true realtime overlay) #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| std::this_thread::yield(); | ||
| } | ||
| } | ||
| double TimestampDeltaToSeconds(uint64_t start, uint64_t end, double period) noexcept |
Collaborator
There was a problem hiding this comment.
Are you always guaranteed to have end be greater than start?
Collaborator
Author
There was a problem hiding this comment.
Yes, but it would be a good idea to foolproof this for future usage / changes!
markgalvan-intel
approved these changes
Aug 29, 2024
Collaborator
markgalvan-intel
left a comment
There was a problem hiding this comment.
This is fantastic. Great stuff! Just the one small question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes fixes for the Asio-based actions (RPC) system, IPC log connection to service, and race condition fix in service
closes #340
closes #344
closes #317