Skip to content

Change Pam's Harvest the Nether script to Fether#1622

Merged
Dream-Master merged 19 commits intomasterfrom
fether-compat
Mar 3, 2026
Merged

Change Pam's Harvest the Nether script to Fether#1622
Dream-Master merged 19 commits intomasterfrom
fether-compat

Conversation

@glowredman
Copy link
Copy Markdown
Member

... and a bit of cleanup (see commit history)

@glowredman glowredman requested a review from a team February 24, 2026 20:20
@glowredman glowredman added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Feb 24, 2026
Comment thread src/main/java/com/dreammaster/gthandler/recipes/BrewingMachineRecipes.java Outdated
Comment thread src/main/java/com/dreammaster/recipes/RecipeRemover.java Outdated
Comment thread src/main/java/com/dreammaster/recipes/ShapedUniversalRecipe.java
Comment thread src/main/java/com/dreammaster/recipes/ShapelessUniversalRecipe.java
Comment thread src/main/java/com/dreammaster/scripts/ScriptAE2FC.java
Comment thread src/main/java/com/dreammaster/scripts/ScriptFether.java Outdated
Comment thread src/main/java/com/dreammaster/scripts/ScriptFether.java Outdated
Comment thread src/main/java/com/dreammaster/recipes/ShapelessUniversalRecipe.java Outdated
Copy link
Copy Markdown
Contributor

@Nikolay-Sitnikov Nikolay-Sitnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once Fether is added to the modpack.

@Dream-Master
Copy link
Copy Markdown
Member

will add it to daxxl asap

@Alexdoru
Copy link
Copy Markdown
Member

Alexdoru commented Mar 3, 2026

could have just made a new file for the new mod instead of removing the file of pam's harvest the nether so we could merge it now and the pam's script won't get loaded when the mod is removed from the pack

@glowredman
Copy link
Copy Markdown
Member Author

could have just made a new file for the new mod instead of removing the file of pam's harvest the nether so we could merge it now and the pam's script won't get loaded when the mod is removed from the pack

Doesn't matter because ther won't be a transition period. All blocks and items are remapped 1:1.

@Dream-Master Dream-Master enabled auto-merge (squash) March 3, 2026 09:54
@Dream-Master Dream-Master merged commit 05eb8fa into master Mar 3, 2026
4 checks passed
@Dream-Master Dream-Master deleted the fether-compat branch March 3, 2026 09:55
@Dream-Master
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor For PRs rewritting a part of the code to have a nicer code overall.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants