This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Elasticsearch mapping and settings refactor#263
Merged
Conversation
added 7 commits
September 18, 2018 11:53
- Removed versions 1.0.0, 1.0.1, and 2.0.0 - Renamed mapping_201.json to mapping. From now on we will have just one mapping file - Renamed mapping_201.json in test_data to mapping.json. This file might be removed as well at some point
- Elasticsearch mappings were updated to be 100% compatible with new features in Elasticsearch 5.x and newer - Text fields were removed from the fields properties following best practices. - String fields were changed to text and keyword types where appropriate. This was done because the string type has been removed. - keyword_ci analyzer was removed since it is no longer needed. All fields that used this analyzer were changed to the keyword type. - the field _fulltext was removed in favor of the keyword field. Now fields that need full text search are of text type from the start with keyword fields where appropriate. - Changed the filter construction code to take into account the new changes to the mappings. - Search and filter properties do not use string as a type. These are constructed using keyword and text types
…icsearch 5.x and above
…patible with ES 5.x and above
seanstar12
pushed a commit
to seanstar12/code-gov-api
that referenced
this pull request
Aug 27, 2019
Elasticsearch mapping and settings refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mappings and settings for Elasticsearch were not completely compatible with Elasticsearch version 5 and above. These were updated and field types were changed to correctly index documents.
Explain the motivation for making this change. What existing problem does the pull request solve?
There were a couple of errors that would show up with very specific searches. These errors would affect the way we were displaying search results on the front-end.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.