Skip to content

Set precision in DTensor::saveToFile properly#55

Merged
alphaville merged 5 commits intomainfrom
hf/max_digits
Nov 29, 2024
Merged

Set precision in DTensor::saveToFile properly#55
alphaville merged 5 commits intomainfrom
hf/max_digits

Conversation

@alphaville
Copy link
Copy Markdown
Member

@alphaville alphaville commented Nov 29, 2024 •
edited
Loading

Main Changes

  • Set precision in DTensor::saveToFile properly
  • DTensor<T>::parseFromTextFile throws std::invalid_argument if T is unsupported

Associated Issues

None

ruairimoran
ruairimoran reviewed Nov 29, 2024
View reviewed changes
ruairimoran
ruairimoran approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit d28cdf8 into main Nov 29, 2024
@alphaville alphaville deleted the hf/max_digits branch December 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alphaville @ruairimoran