Skip to content

Reduction of unnecessary downloads from GPU#52

Merged
alphaville merged 14 commits intomainfrom
feature/debug-mode
Nov 25, 2024
Merged

Reduction of unnecessary downloads from GPU#52
alphaville merged 14 commits intomainfrom
feature/debug-mode

Conversation

@alphaville
Copy link
Copy Markdown
Member

@alphaville alphaville commented Nov 21, 2024

Main Changes

  • Extra checks only if GPUTILS_DEBUG_MODE is defined
  • methods do not return a status code now
  • status code accessible with a getter (docs written)

Associated Issues

None

About:
- Extra checks only if GPUTILS_DEBUG_MODE is defined
- methods do not return a status code now
- status code accessible with a getter (docs written)
@alphaville alphaville marked this pull request as ready for review November 21, 2024 16:27
About:
- IStatus is subclassed by all classes that need a device-based status code
Copy link
Copy Markdown
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments. Also, there appears to be a memory leak

Copy link
Copy Markdown
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit 7d7b63e into main Nov 25, 2024
@alphaville alphaville deleted the feature/debug-mode branch December 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants