Added possibility to set own sorting for each checklist (#81)#82
Merged
naveensingh merged 10 commits intoFossifyOrg:masterfrom May 6, 2025
Merged
Added possibility to set own sorting for each checklist (#81)#82naveensingh merged 10 commits intoFossifyOrg:masterfrom
naveensingh merged 10 commits intoFossifyOrg:masterfrom
Conversation
7 tasks
Member
|
Sorting seems to be working fine. That's a clever reuse of per-folder sorting functions :)
I know you put in the effort here but this adds too much flexibility to this option. It's better to move it back into settings and keep it global (as discussed sometime ago!). That’ll keep things simpler, both code-wise and UX-wise. Thanks. |
Member
|
Does it happen to you too? |
Member
|
I'm working on it. |
naveensingh
approved these changes
May 6, 2025
Member
naveensingh
left a comment
There was a problem hiding this comment.
Fixed the bug. Everything else looks good, merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
customSortinglogic from Commons.customSortingin other apps, and "custom sorting" means something different here, I've created helpers with the nameownSorting.moveDoneChecklistItemsto be part ofconfig.sorting, so it's also possible to set it separately for each checklist.config.sorting, similarly as showing items count has been done in Gallery's grouping options.moveDoneChecklistItemsvalue to be a flag in a currentconfig.sorting.Before/After Screenshots/Screen Record
qemu-system-x86_64_1GqMvlYkTT.mp4
Fixes the following issue(s)
Acknowledgement