Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 97.27% 97.46% +0.18%
==========================================
Files 22 23 +1
Lines 772 829 +57
==========================================
+ Hits 751 808 +57
Misses 21 21 ☔ View full report in Codecov by Sentry. |
Member
|
@AlexV525 |
0340f6f to
c315e19
Compare
Member
Author
|
Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them. |
Merged
wasabeef
added a commit
that referenced
this pull request
Jun 25, 2024
## 5.6.0 **Bug fix** - [#530](#530) Fix the Flavored assets. by [@AlexV525](https://github.com/AlexV525) - Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them. - [#532](#532) Provid the theme to SvgAssetLoader instead of SvgPicture. by [@Kirpal](https://github.com/Kirpal)
2 tasks
bluesky950520
pushed a commit
to bluesky950520/flutter_gen-edit
that referenced
this pull request
Mar 11, 2025
## 5.6.0 **Bug fix** - [#530](FlutterGen/flutter_gen#530) Fix the Flavored assets. by [@AlexV525](https://github.com/AlexV525) - Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them. - [#532](FlutterGen/flutter_gen#532) Provid the theme to SvgAssetLoader instead of SvgPicture. by [@Kirpal](https://github.com/Kirpal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Resolves #494 🎯
Generated assets would contain the flavor info specified in the
pubspec.yaml, but only as a constant that is not involved with actual flavoring.Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)