Conversation
`flow nodeTemplate:fromSubtree <nodeIdentifier>`
4e61058 to
68f0025
Compare
Also improve dumper
…s work with access to the data
This is helpful in case you have many properties, and some properties have say names evolved historically
Sebobo
left a comment
There was a problem hiding this comment.
Great change, left some comments
- mainContentCollection: + 'Content Collection (main)':
…lateYamlDumpFromNodeSubtree
Sebobo
left a comment
There was a problem hiding this comment.
Works great ❤️ but can you add instructions to the readme?
lorenzulrich
left a comment
There was a problem hiding this comment.
Thanks, great work!
| * @param string $workspaceName | ||
| * @return void | ||
| */ | ||
| public function fromSubtreeCommand(string $startingNodeId, string $workspaceName = 'live'): void |
There was a problem hiding this comment.
For my taste, a command name should contain a verb, e.g. createConfigurationForSubtree. Furthermore, "Subtree" is a term that is not really known to integrators. In Docs and ReadTheDocs, there are three mentions of this term (one of the referring to Git subtree), so I suggest to use a more common term.
Idea: dumpConfigurationForNodeTree
There was a problem hiding this comment.
Hi thanks for your review. The naming subtree is taken from the new ESCR, where you can actually get with one sql query the whole subtree:
ContentSubgraphInterface::findSubtree
A subtree will look like this
so i like to keep the name subtree (maybe we can add the prefix node so people understand its node releated?: NodeSubtree)
but i agree that something like a verb could also be a nice addition to the command name:
# original
flow nodeTemplate:fromSubtree <nodeIdentifier>
# your proposal
flow nodeTemplate:createConfigurationForSubtree <nodeIdentifier>
# your other proposal
flow nodeTemplate:dumpConfigurationForNodeTree <nodeIdentifier>
# my idea:
flow nodeTemplate:createFromNodeSubtree <nodeIdentifier>
@Sebobo and me decided for now on nodeTemplate:createFromNodeSubtree
flow nodeTemplate:createFromNodeSubtree <nodeIdentifier>closes: #37
also adds a first near-e2e test ;) #33
when creating a more complex node template, to create multiple pages and content elements, it can be helpful to take the current node subtree as reference. For this case a command controller would be great.