Skip to content

FEATURE: Allow for extensibility via options and signal #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimaip merged 2 commits into from
Apr 12, 2018
Merged

FEATURE: Allow for extensibility via options and signal #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c25d5d
FEATURE: Allow for extensibility via options and signal
Apr 12, 2018
e8db2e4
Improve comment
Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Classes/Template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ class Template
*/
protected $childNodes;

/**
* Options can be used to configure third party processing
*
* @var array
*/
protected $options;

/**
* @var string
*/
Expand Down Expand Up @@ -67,6 +74,7 @@ class Template
* @param string $name
* @param array $properties
* @param array<Template> $childNodes
* @param array $options
* @param string $when
* @param string $withItems
*/
Expand All @@ -75,13 +83,15 @@ public function __construct(
$name = null,
array $properties = [],
array $childNodes = [],
array $options = [],
$when = null,
$withItems = null
) {
$this->type = $type;
$this->name = $name;
$this->properties = $properties;
$this->childNodes = $childNodes;
$this->options = $options;
$this->when = $when;
$this->withItems = $withItems;
}
Expand All @@ -107,6 +117,8 @@ public function apply(NodeInterface $node, array $context)
foreach ($this->childNodes as $childNodeTemplate) {
$childNodeTemplate->createOrFetchAndApply($node, $context);
}

$this->emitNodeTemplateApplied($node, $context, $this->options);
}

/**
Expand Down Expand Up @@ -200,4 +212,18 @@ protected function setProperties(NodeInterface $node, array $context)
}
}
}

/**
* Signals that a node template has been applied to the given node.
*
* @param NodeInterface $node
* @param array $context
* @param array $options
* @return void
* @Flow\Signal
* @api
*/
public function emitNodeTemplateApplied(NodeInterface $node, array $context, array $options)
{
}
}