Merged
Conversation
tomholub
reviewed
Apr 2, 2022
FlowCrypt/Functionality/Services/Account Server Services/EnterpriseServerApi.swift
Outdated
Show resolved
Hide resolved
FlowCryptAppTests/Functionality/Services/ComposeMessageServiceTests.swift
Outdated
Show resolved
Hide resolved
tomholub
approved these changes
Apr 4, 2022
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
I'm approving but would like to discuss the below point in another issue.
| return nil // on consumer installations, we only use FES if it returns as expected | ||
| } | ||
| let helper = EnterpriseServerApiHelper() | ||
| self.fesUrl = try await helper.getActiveFesUrl(for: email) |
Collaborator
There was a problem hiding this comment.
I wonder - could there be situations when EnterpriseServerApi is initiated but a call to check if FES is active is not actually needed in that moment? We could maybe instead have fesUrl as a lazy computed property?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
emailproperty toEnterpriseServerApito be able to fetchfesUrlonly onceclose #1348
Tests (delete all except exactly one):
EnterpriseServerApiTestsTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):