Skip to content

#953 Add 'reply all' functionality#1356

Merged
sosnovsky merged 9 commits intomasterfrom
feature/issue-953-reply-all
Feb 3, 2022
Merged

#953 Add 'reply all' functionality#1356
sosnovsky merged 9 commits intomasterfrom
feature/issue-953-reply-all

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Feb 1, 2022 •
edited by tomholub
Loading

This PR adds reply all action on messages screen

close #953

Tests (delete all except exactly one):

  • Tests added or updated - updated CheckReplyAndForwardForEncryptedEmail test to check reply all functionality

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky
Copy link
Collaborator Author

sosnovsky commented Feb 2, 2022

I added Reply all to message actions menu:

Simulator.Screen.Recording.-.iPhone.13.-.2022-02-02.at.13.03.59.mp4

@tomholub after this task I have only #954 left in 0.8.0 milestone. Should I also take #1337 and #1348 tasks?

@sosnovsky sosnovsky marked this pull request as ready for review February 2, 2022 11:10
@sosnovsky sosnovsky requested a review from tomholub February 2, 2022 11:10
tomholub
tomholub reviewed Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - will test the app now

tomholub
tomholub requested changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments above

@sosnovsky sosnovsky requested a review from tomholub February 2, 2022 21:24
@sosnovsky sosnovsky merged commit 68b7fa4 into master Feb 3, 2022
@sosnovsky sosnovsky deleted the feature/issue-953-reply-all branch February 3, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholub tomholub tomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reply all functionality

2 participants

@sosnovsky @tomholub