Skip to content

#1327 Fix public key refetch#1347

Merged
sosnovsky merged 6 commits intomasterfrom
bugfix/issue-1327-trash-button
Jan 31, 2022
Merged

#1327 Fix public key refetch#1347
sosnovsky merged 6 commits intomasterfrom
bugfix/issue-1327-trash-button

Conversation

@sosnovsky
Copy link
Collaborator

This PR fixes recipients keys refetch after manual deletion in Settings -> Contacts

close #1327


Tests (delete all except exactly one):

  • Tests will be added later (issue #...)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub January 28, 2022 10:52
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below

@sosnovsky sosnovsky marked this pull request as draft January 28, 2022 13:41
@sosnovsky
Copy link
Collaborator Author

I updated code to use new logic - recipient UI is rendered after retrieving local contact and it's updated if new keys were fetched in background:

Simulator.Screen.Recording.-.iPhone.13.-.2022-01-31.at.13.58.44.mp4

@sosnovsky sosnovsky marked this pull request as ready for review January 31, 2022 15:34
@sosnovsky sosnovsky requested a review from tomholub January 31, 2022 15:34
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 51b5e4e into master Jan 31, 2022
@sosnovsky sosnovsky deleted the bugfix/issue-1327-trash-button branch January 31, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistency between contact trash icon and public key trash icon result

2 participants