#1306 Add message password policy

[sosnovsky]

This PR adds message password policy for checking password strength

close #1306

---

Tests (delete all except exactly one):

• Tests added or updated - updated SendEmailToRecipientWithoutPublicKey test

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[sosnovsky]

@tomholub here is a video of current implementation:

Simulator.Screen.Recording.-.iPhone.13.-.2022-01-24.at.14.56.55.mp4

What about notifying users about weak password before tapping Send - for example, we can show warning instead of green Web portal password added message. Do we need it or current implementation is enough for now?

[tomholub]

What about notifying users about weak password before tapping Send - for example, we can show warning instead of green Web portal password added message. Do we need it or current implementation is enough for now?

Agree, actually best would be still on the modal where the user inputs it.

Best would be:

• the modal should describe the requirements for the password
• there should be visual indication to show if the password is sufficient. Maybe color of the input and the set button
• user should not be allowed to set it unless it fits the requirements

I don't know if we are trying to do more than what is reasonable to expect from a modal - do you think this needs its own view? Or should modal be enough for this?

[tomholub]

On browser extension we color it in red while it's non-conforming, plus it shows the requirements above:

On Android it evaluates them one by one which is an overkill, I don't want to do that on iOS. But again there is indication if it conforms + list of requirements.

[sosnovsky]

I think it's possible to do such check using UIAlertViewController - Set button will be disabled until all requirements are met. And I'll also add all requirements to add password modal

[sosnovsky]

I updated implementation to check password strength when user types it in modal, here is video:

Simulator.Screen.Recording.-.iPhone.13.-.2022-01-25.at.16.02.53.mp4

[tomholub]

Yup - simple, effective, clear.

[tomholub]

Code looks good 👍

[tomholub]

👍