Skip to content

Comments

store google_token_access in memory#4238

Merged
rrrooommmaaa merged 1 commit intomasterfrom
issue-4196-google-token-access-in-memory
Jan 13, 2022
Merged

store google_token_access in memory#4238
rrrooommmaaa merged 1 commit intomasterfrom
issue-4196-google-token-access-in-memory

Conversation

@rrrooommmaaa
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa commented Jan 7, 2022

This PR store google_token_access in memory, correctly managing expiration

close #4196


Tests (delete all except exactly one):

  • Tests added or updated (google access toke extraction is updated)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Still marked as draft - if it's ready for merging, you can mark it as ready & merge it.

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review January 13, 2022 20:11
@rrrooommmaaa rrrooommmaaa merged commit daf4f81 into master Jan 13, 2022
@rrrooommmaaa rrrooommmaaa deleted the issue-4196-google-token-access-in-memory branch January 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google access token to be stored in-memory

2 participants