Skip to content

Comments

Issue 4194 refresh id token#4195

Merged
tomholub merged 5 commits intomasterfrom
issue-4194-refresh-id-token
Dec 16, 2021
Merged

Issue 4194 refresh id token#4195
tomholub merged 5 commits intomasterfrom
issue-4194-refresh-id-token

Conversation

@tomholub
Copy link
Collaborator

@tomholub tomholub commented Dec 15, 2021

This PR:

  • removes DISABLE_FES_ACCESS_TOKEN org rules (which now became the default and only option, we are deprecating FES access tokens completely)
  • refreshes id token transparently in background instead of asking user to re-authenticate

close #4194


Tests:

  • Tests removed / updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub tomholub marked this pull request as ready for review December 15, 2021 17:04
@tomholub
Copy link
Collaborator Author

@rrrooommmaaa could you please take a look?

Copy link
Contributor

@rrrooommmaaa rrrooommmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like seeing stuff deleted! 👍

@tomholub tomholub merged commit 1fea232 into master Dec 16, 2021
@tomholub tomholub deleted the issue-4194-refresh-id-token branch December 16, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto-refresh id token instead of asking user to re-authenticate

2 participants