Skip to content

refactored dearmor and added tests#3427

Merged
tomholub merged 9 commits intomasterfrom
issue-3407-dearmor-tests
Feb 16, 2021
Merged

refactored dearmor and added tests#3427
tomholub merged 9 commits intomasterfrom
issue-3407-dearmor-tests

Conversation

@rrrooommmaaa
Copy link
Contributor

This PR properly tests dearmor

close #3407

@rrrooommmaaa rrrooommmaaa force-pushed the issue-3407-dearmor-tests branch from 48136a8 to 3bcdd21 Compare February 15, 2021 11:48
@limonte
Copy link

limonte commented Feb 15, 2021

The live Gmail test secure reply btn, reply draft is most probably failing not due to this PR, I'll take care of it separately.

@rrrooommmaaa
Copy link
Contributor Author

The live Gmail test secure reply btn, reply draft is most probably failing not due to this PR, I'll take care of it separately.

I moved the memory-intensive test to flaky. Let's see if it helps

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review February 15, 2021 14:30
tomholub
tomholub previously approved these changes Feb 15, 2021
tomholub
tomholub previously approved these changes Feb 16, 2021
@tomholub tomholub merged commit 67930a9 into master Feb 16, 2021
@tomholub tomholub deleted the issue-3407-dearmor-tests branch February 16, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly test KeyUtil.dearmor and possibly move to a different class

3 participants