Skip to content

return unarmored keys from WKD mock#3404

Merged
tomholub merged 1 commit intomasterfrom
issue-3402-wkd-mock-dearmor
Feb 8, 2021
Merged

return unarmored keys from WKD mock#3404
tomholub merged 1 commit intomasterfrom
issue-3402-wkd-mock-dearmor

Conversation

@rrrooommmaaa
Copy link
Contributor

This PR makes Wkd mock return unarmored keys

close #3402

@rrrooommmaaa rrrooommmaaa force-pushed the issue-3402-wkd-mock-dearmor branch from f54a980 to f413b17 Compare February 8, 2021 18:57
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you

@tomholub tomholub merged commit e26a8a1 into master Feb 8, 2021
@tomholub tomholub deleted the issue-3402-wkd-mock-dearmor branch February 8, 2021 20:25
@rrrooommmaaa
Copy link
Contributor Author

@tomholub I'm a bit concerned about not having properly tested KeyUtil.dearmor as it's unclear how it works on incorrect or large inputs. It's good enough for test infrastructure, but we sort of exposed it to further usage within the app.
And about naming: it dearmors not only keys, should we move it to a different class?

@tomholub
Copy link
Collaborator

tomholub commented Feb 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mock WKD should be returning unarmored keys

2 participants