Merged
Conversation
f54a980 to
f413b17
Compare
Contributor
Author
|
@tomholub I'm a bit concerned about not having properly tested |
Collaborator
|
Agree. Feel free to test it further and move it.
…On Tue, 9 Feb 2021, 10:09 Roman, ***@***.***> wrote:
@tomholub <https://github.com/tomholub> I'm a bit concerned about not
having properly tested KeyUtil.dearmor as it's unclear how it works on
incorrect or large inputs. It's good enough for test infrastructure, but we
sort of exposed it to further usage within the app.
And about naming: it dearmors not only keys, should we move it to a
different class?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQDZENU5YRDOY4U7NI2YCLS6D3UFANCNFSM4XJP7J2Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Wkd mock return unarmored keys
close #3402