Report issues with parsing inline images#3350
Conversation
|
The better review experience would be with |
| img.setAttribute('src', `cid:${imgAttachment.cid}`); | ||
| imgAttachments.push(imgAttachment); | ||
| } else { | ||
| Catch.report(`Unable to parse an inline image with src="${src}"`); |
There was a problem hiding this comment.
This reports it to us - not good - a privacy violation. You can instead do a toast to tell the user.
There was a problem hiding this comment.
Instead of toast I decided to go with the error modal which was already implemented there.
The current behavior is: we will NOT send a message if there were issues with parsing inline images, IMO it's better to prevent sending a message which is broken because of unexpected issues. @tomholub Let me know if you want some other behavior here, e.g. remove broken images and send a message without them.
extension/chrome/elements/compose-modules/compose-send-btn-module.ts
Outdated
Show resolved
Hide resolved
327b8c6 to
802f9a0
Compare
tomholub
left a comment
There was a problem hiding this comment.
Looks good, thank you both 👍
This PR reports issues with parsing inline images to track issues with unexpected
srcvalues of inline images (#3301 (comment))close #3301