no-explicit-any warnings - prefer unknown

[tomholub]

It seems we have delayed after-effects after this merge. #4284 https://flowcrypt.semaphoreci.com/jobs/47dbcb8e-5bc4-437a-9812-e70699e7d855

They are all warnings, except for

   148:4   error    Missing semicolon                         @typescript-eslint/semi 00:09 

In either case, we should try to address these warnings - I'll file an issue.

Originally posted by @tomholub in #4484 (comment)

[tomholub]

@martgil you can take 5 of these warnings and convert any to unknown in the code, and make a PR.

If the reviewer is happy with the result, then you could try to address the rest, gradually.

[tomholub]

I agree in general. But it may be a lot of work that I may not want to immediately block developer time for :-)

I'd do two steps - in first step, convert all to unknown (Mart, who is not a developer, could still do this) and then in the PR review we'll highlight the areas where we really need more proper types, and focus on that in another PR.

unknown is not too bad btw. any means anything goes, anything is correct. unknown means the compiler doesn't know the type and you have to test the value to determine what type it is, in order to use it. It's a pretty safe type when handled appropriately.

I think a lot of the any will be thrown errors (today declared as any) where unknown is more appropriate.

Most of the any situations will probably come from missing types on libraries. So we'll have to write <library>.d.ts files for them which may not be trivial, for some of them. But it could later be filed as a separate issue eg add types for library X that will solve 50 any/unknowns at once.

[rrrooommmaaa]

I still see a lot of warnings.