Skip to content

Pass phrase dialogs called during backup checks aren't working properly #4059

@rrrooommmaaa

Description

@rrrooommmaaa

Following PR #3973
The code logic in encryptForBackup() method (formerly inside backupOnEmailProviderAndUpdateUi()) activates passphrase frame by sending passphrase_dialog message to the hosting page. The passphrase frame is shown ok, and after its completion (waitUntilPassphraseChanged call), the backup procedure was supposed to continue. However, this never happens as the passphrase frame seems to wipe out the backup frame (probably because they are both set up with Ui.modal.iframe that doesn't expect to keep more than one). So the backup procedure terminates without a proper warning, and the test settings - manual backup a key with a missing pass phrase is by now incomplete.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions