show all fingerprints when hovering over recipient

[tomholub]

In the past, we used to only have one public key possible per recipient. After that, we refactored some code to allow more than one public key. So now, if I email joe@example.com, I may have 3 public keys recorded for them locally, and encrypt the message for all three public keys.

However, when I hover over the recipient in compose box, it will only show one of the public key fingerprints. This is because we didn't refactor all of the code, and somewhere we pull just one public key instead of pulling all as we should to display this.

Instead, it should be showing the primary fingerprint of each public key we have recorded for that person.

Feel free to ask rrrooommmaaa where you need questions asked about the codebase.

[IvanPizhenko]

@rrrooommmaaa Here's what I've found in the code (extension/chrome/elements/compose-modules/compose-recipients-module.ts):

      $(el).attr('title', 'Does use encryption' + this.recipientKeyIdText(contact));

and then

  private recipientKeyIdText = (contact: Contact) => {
    if (contact.fingerprint) {
      return `\n\nRecipient public key fingerprint:\n${Str.spaced(contact.fingerprint)}`;
    } else {
      return '';
    }
  }

And then (extension/js/common/core/crypto/key.ts)

export type Contact = {
  email: string;
  name: string | null;
  pubkey: Key | undefined;
  hasPgp: 0 | 1;
  fingerprint: string | null;
  lastUse: number | null;
  pubkeyLastCheck: number | null;
  expiresOn: number | null;
  revoked: boolean;
};

So finally Contact has only one key and fingerprint, and I assume we need to bring there multiple ones.

[IvanPizhenko]

So now, if I email joe@example.com, I may have 3 public keys recorded for them locally, and encrypt the message for all three public keys.

@rrrooommmaaa where does encryption with all keys happens in the code?

[IvanPizhenko]

@rrrooommmaaa any ideas how should we proceed with this one? Seems like changing Contact will make it incompatible with existing contact database, which should be somehow migrated then.

[tomholub]

Instead of changing Contact (not desired), you would be passing around an array of Contact[]. Then, wherever it currently uses some ContactStore method that only pulls a single Contact, you would instead use another existing ContactStore method that returns Contact[] and pass the array around to display here.

where does encryption with all keys happens in the code?

For encryption, public keys are currently pulled at general-mail-formatter.ts, this line:

const { pubkeys, emailsWithoutPubkeys } = await view.storageModule.collectAllAvailablePublicKeys(newMsgData.from, senderKi, recipientsEmails);

[IvanPizhenko]

@tomholub ok, but then there is another question - how do we display expired/revoked/"no pgp" statuses in this case? Currently the code checks some fields of the contact and displays statuses based on that:

if (contact.pubkey && ((contact.expiresOn || Infinity) <= Date.now() || contact.pubkey.usableForEncryptionButExpired)) {
      recipient.status = RecipientStatus.EXPIRED;
    ....
} else if (contact.revoked) {
      recipient.status = RecipientStatus.REVOKED;
    ....
else if (contact.pubkey) {
      recipient.status = RecipientStatus.HAS_PGP;
   ....
    // here we will use array to display all fingerprints
else {
      recipient.status = RecipientStatus.NO_PGP;
    ....
}

Now look at the above code and assume contact will be array of Contact. How to display statuses in this case? Is it reliable to just take first element and display based on it? Or should there be some more sophisticated logic?

[tomholub]

The logic would be:

• if there is at least one valid (non-expired, non-revoked) public key, then it's HAS_PGP
• else if there is at least one expired public key, then it's EXPIRED
• else if there is at least one revoked key, then REVOKED
• else it's NO_PGP

If you will be always rendering from there, with all of this information, then you could list all fingerprints in the black tooltip, for example as follows:

Valid public key fingerprints:
aaaa (openpgp)
bbbb (openpgp)

Expired public key fingerprints:
cccc (openpgp)

Revoked public key fingerprints:
ddd (openpgp)

So if there are no valid, you would render:

Expired public key fingerprints:
cccc (openpgp)

Revoked public key fingerprints:
ddd (openpgp)

If there are only valid, then:

Valid public key fingerprints:
aaaa (openpgp)
bbbb (openpgp)

If it's actually an S/MIME key that you came across:

Valid public key fingerprints:
aaaa (s/mime)

That will be easier for debugging. Thanks!

[IvanPizhenko]

lookupPubkeyFromKeyserversThenOptionallyFetchExpiredByFingerprintAndUpsertDb rocks!
The longest human-invented method name in the real project I've ever seen.