Thunderbird signed + encrypted message - shows "Message Not Signed" in FlowCrypt [waiting for OpenPGP.js upgrade]

[limonte]

UPDATE Seems like openpgp.js issue. We will upgrade to v5 in the #3324.

While working on #3941 I sent 3 types of messages to ci.tests.gmail@flowcrypt.dev:

• signed html (all good)
• signed text (all good)
• signed + encrypted html (faced issues)

Here's how it looks like in Thunderbird:

And here's how it looks in FlowCrypt:

[tomholub]

@IvanPizhenko could you please later triage this to see if the problem comes from OpenPGP.js or from our own code?

[IvanPizhenko]

ok, will try

[IvanPizhenko]

Reproduced this.

[IvanPizhenko]

From the following debug code:

  private static cryptoMsgGetSignedBy = async (msg: OpenpgpMsgOrCleartext, keys: SortedKeysForDecrypt) => {
    console.log(">>>> cryptoMsgGetSignedBy: entered");
    console.log(">>>> cryptoMsgGetSignedBy: Message: " + JSON.stringify(msg));
    console.log(">>>> cryptoMsgGetSignedBy: Keys: " + JSON.stringify(keys));
    if (msg.getSigningKeyIds) {
      console.log(">>>> cryptoMsgGetSignedBy: signing key Ids: "
        + JSON.stringify(msg.getSigningKeyIds()));
    } else {
      console.log(">>>> cryptoMsgGetSignedBy: NO signing key Ids");
    }
    keys.signedBy = Value.arr.unique(msg.getSigningKeyIds ? msg.getSigningKeyIds().map(kid => OpenPGPKey.bytesToLongid(kid.bytes)) : []);
    console.log(">>>> cryptoMsgGetSignedBy: Keys.signedBy: " + JSON.stringify(keys.signedBy));
....

I am getting following output:

>>>> cryptoMsgGetSignedBy: entered
​ >>>> cryptoMsgGetSignedBy: Message: 
{"packets":{"0":{"tag":1,"version":3,"publicKeyId":{"bytes":"TòHB�â��"},"publicKeyAlgorithm":"ecdh","sessionKey":null,
"sessionKeyAlgorithm":null,"encrypted":[{"data":{"0":64,"1":76,"2":31,"3":76,"4":229,"5":208,"6":157,"7":79,"8":99,"9":
212,"10":201,"11":108,"12":0,"13":96,"14":7,"15":136,"16":119,"17":74,"18":123,"19":94,"20":158,"21":78,"22":216,"23":54
,"24":127,"25":53,"26":128,"27":231,"28":128,"29":230,"30":143,"31":44,"32":123}},{"data":{"0":154,"1":155,"2":42,"3":
208,"4":101,"5":181,"6":71,"7":186,"8":193,"9":52,"10":108,"11":156,"12":222,"13":92,"14":90,"15":98,"16":173,"17":214,
"18":45,"19":104,"20":24,"21":71,"22":53,"23":124,"24":182,"25":83,"26":217,"27":20,"28":136,"29":41,"30":168,"31":208,
"32":105,"33":253,"34":163,"35":58,"36":18,"37":16,"38":102,"39":168,"40":194,"41":209,"42":113,"43":216,"44":208,"45":
187,"46":254,"47":102}}],"packets":{"length":0},"fromStream":false},"1":{"tag":1,"version":3,"publicKeyId":{"bytes":"KZ/
üæ-�\u0001"},"publicKeyAlgorithm":"rsa_encrypt_sign","sessionKey":null,"sessionKeyAlgorithm":null,"encrypted":[{"data":{
"0":167,"1":223,"2":217,"3":100,"4":77,"5":122,"6":23,"7":101,"8":137,"9":63,"10":128,"11":88,"12":255,"13":90,"14":179,
"15":96,"16":175,"17":66,"18":124,"19":245,"20":52,"21":49,"22":27,"23":171,"24":248,"25":105,"26":110,"27":36,"28":198,
"29":41,"30":106,"31":254,"32":196,"33":40,"34":20,"35":166,"36":224,"37":21,"38":228,"39":142,"40":115,"41":174,"42":
251,"43":215,"44":218,"45":235,"46":156,"47":197,"48":167,"49":212,"50":56,"51":131,"52":140,"53":196,"54":178,"55":98,
"56":244,"57":223,"58":105,"59":239,"60":164,"61":6,"62":189,"63":47,"64":63,"65":92,"66":27,"67":204,"68":87,"69":53,
"70":42,"71":29,"72":236,"73":57,"74":3,"75":153,"76":123,"77":13,"78":86,"79":98,"80":129,"81":66,"82":104,"83":136,
"84":87,"85":82,"86":15,"87":240,"88":111,"89":190,"90":6,"91":88,"92":187,"93":58,"94":80,"95":2,"96":127,"97":53,"98":
173,"99":71,"100":131,"101":44,"102":94,"103":71,"104":234,"105":199,"106":78,"107":242,"108":234,"109":168,"110":184,
"111":135,"112":105,"113":46,"114":31,"115":241,"116":51,"117":182,"118":77,"119":168,"120":107,"121":170,"122":78,"123"
:135,"124":241,"125":28,"126":43,"127":124,"128":225,"129":132,"130":0,"131":110,"132":69,"133":124,"134":199,"135":124,
"136":93,"137":179,"138":78,"139":233,"140":20,"141":164,"142":0,"143":238,"144":96,"145":87,"146":106,"147":67,"148":
243,"149":145,"150":88,"151":6,"152":42,"153":67,"154":174,"155":116,"156":58,"157":165,"158":168,"159":71,"160":45,
"161":221,"162":171,"163":210,"164":176,"165":19,"166":107,"167":232,"168":199,"169":170,"170":115,"171":228,"172":173,
"173":38,"174":15,"175":185,"176":189,"177":217,"178":157,"179":187,"180":216,"181":11,"182":154,"183":125,"184":112,
"185":145,"186":225,"187":211,"188":135,"189":185,"190":149,"191":207,"192":144,"193":109,"194":231,"195":58,"196":211,
"197":38,"198":212,"199":135,"200":2,"201":183,"202":115,"203":230,"204":46,"205":122,"206":90,"207":110,"208":151,"209"
:227,"210":251,"211":45,"212":220,"213":227,"214":88,"215":35,"216":173,"217":49,"218":53,"219":170,"220":78,"221":54,
"222":118,"223":194,"224":168,"225":92,"226":50,"227":254,"228":72,"229":27,"230":174,"231":85,"232":236,"233":37,"234":
41,"235":106,"236":83,"237":61,"238":30,"239":124,"240":140,"241":115,"242":53,"243":222,"244":52,"245":226,"246":255,
"247":243,"248":215,"249":106,"250":32,"251":91,"252":204,"253":41,"254":160,"255":146,"256":63,"257":106,"258":40,"259"
:114,"260":68,"261":176,"262":221,"263":232,"264":12,"265":50,"266":192,"267":64,"268":38,"269":18,"270":48,"271":125,
"272":92,"273":54,"274":95,"275":90,"276":45,"277":200,"278":85,"279":239,"280":91,"281":165,"282":251,"283":66,"284":59
,"285":40,"286":249,"287":233,"288":190,"289":252,"290":171,"291":41,"292":252,"293":221,"294":90,"295":180,"296":176,
"297":22,"298":152,"299":64,"300":67,"301":91,"302":75,"303":235,"304":105,"305":132,"306":10,"307":161,"308":148,"309":
218,"310":144,"311":39,"312":198,"313":237,"314":167,"315":224,"316":248,"317":163,"318":3,"319":234,"320":88,"321":110,
"322":194,"323":189,"324":191,"325":60,"326":95,"327":84,"328":154,"329":22,"330":194,"331":67,"332":69,"333":243,"334":
64,"335":29,"336":155,"337":13,"338":255,"339":177,"340":107,"341":83,"342":172,"343":143,"344":200,"345":81,"346":48,
"347":38,"348":65,"349":63,"350":126,"351":75,"352":155,"353":240,"354":19,"355":82,"356":126,"357":30,"358":110,"359":
151,"360":89,"361":4,"362":55,"363":110,"364":139,"365":99,"366":196,"367":115,"368":113,"369":6,"370":253,"371":138,
"372":221,"373":164,"374":126,"375":116,"376":117,"377":194,"378":192,"379":184,"380":196,"381":192,"382":18,"383":4,
"384":44,"385":173,"386":60,"387":143,"388":144,"389":21,"390":249,"391":7,"392":123,"393":136,"394":14,"395":211,"396":
122,"397":170,"398":56,"399":76,"400":22,"401":34,"402":11,"403":57,"404":56,"405":79,"406":15,"407":233,"408":17,"409":
219,"410":185,"411":210,"412":220,"413":28,"414":124,"415":64,"416":206,"417":134,"418":231,"419":233,"420":155,"421":
201,"422":225,"423":23,"424":171,"425":132,"426":145,"427":171,"428":28,"429":123,"430":199,"431":108,"432":249,"433":
183,"434":250,"435":102,"436":148,"437":179,"438":69,"439":23,"440":166,"441":103,"442":43,"443":17,"444":141,"445":155,
"446":120,"447":155,"448":55,"449":4,"450":123,"451":191,"452":210,"453":125,"454":73,"455":74,"456":205,"457":101,"458"
:206,"459":90,"460":166,"461":19,"462":163,"463":17,"464":246,"465":87,"466":119,"467":139,"468":102,"469":42,"470":80,
"471":133,"472":61,"473":105,"474":47,"475":151,"476":207,"477":140,"478":124,"479":19,"480":126,"481":234,"482":122,
"483":242,"484":245,"485":247,"486":135,"487":79,"488":244,"489":157,"490":68,"491":46,"492":21,"493":126,"494":230,
"495":43,"496":161,"497":173,"498":107,"499":137,"500":44,"501":90,"502":62,"503":58,"504":80,"505":37,"506":98,"507":
129,"508":30,"509":2,"510":144,"511":238}}],"packets":{"length":0},"fromStream":false},"2":{"tag":18,"version":1,
"encrypted":{},"modification":false,"packets":{"length":0},"fromStream":false},"length":3,"stream":{}},"fromStream":
false}
​ >>>> cryptoMsgGetSignedBy: Keys: 
{"verificationContacts":[],"forVerification":[],"encryptedFor":["54F2484284E2928D","4B5A2FFCE62D9501"],"signedBy":[],
"prvMatching":[],"prvForDecrypt":[],"prvForDecryptDecrypted":[],"prvForDecryptWithoutPassphrases":[]}
​ >>>> cryptoMsgGetSignedBy: signing key Ids: []
​ >>>> cryptoMsgGetSignedBy: Keys.signedBy: []
​ 

Note that signing key Ids: [] is empty. So my conclusion is that it is likely openpgp.js issue, because this is returned by the method Openpgp.message.Message.getSigningKeyIds().