Skip to content

Comments

Improve sending feedback#1938

Merged
DenBond7 merged 3 commits intomasterfrom
issue_1820_improve_sending_feedbacks
Aug 10, 2022
Merged

Improve sending feedback#1938
DenBond7 merged 3 commits intomasterfrom
issue_1820_improve_sending_feedbacks

Conversation

@DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Aug 8, 2022

This PR improved sending feedback.

close #1820


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)
  • Difficult to test (explain why)
  • Not worth testing
  • Tests will be added later (issue #...)
  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review August 9, 2022 12:10
@DenBond7 DenBond7 requested a review from IvanPizhenko as a code owner August 9, 2022 12:10
Copy link
Contributor

@IvanPizhenko IvanPizhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, couple of comments.

@DenBond7 DenBond7 merged commit 7a2d977 into master Aug 10, 2022
@DenBond7 DenBond7 deleted the issue_1820_improve_sending_feedbacks branch August 10, 2022 07:09
@DenBond7 DenBond7 modified the milestones: 1.5.0, 1.3.8 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate FeedbackJobIntentService to WorkManager or use another approach

2 participants