issue #1347 Detect wrong armor checksum#1371
Conversation
| } catch (ex: Exception) { | ||
| if ( | ||
| ex is IOException && | ||
| ex.message?.contains("crc check failed in armored message") == true |
There was a problem hiding this comment.
Does PGPainless return exception as IOException? it would be better to have a predefined exception here. For now, it looks a little ugly
|
@IvanPizhenko it seems JUnit tests were broken. Please look at them. |
|
@DenBond7 thanks for noting this, will have a look. |
|
@DenBond7 that's new issue arised as result of changes in the PGPainless which we asked for, see more details in this comment #1347 (comment) |
|
The fact our tests discovered this means they are pretty good - well done with the tests on this repo. |
|
@DenBond7 I think I've got it working, please recheck. |
|
@DenBond7 I can't get "Instrumentation tests(with email server)" pass in CI. Rerun few times with no luck. This is not first time that it happens. Any ideas how to solve/improve this? |
Please mark failed tests as @NotReadyForCI. I will look at them later. |
…phraseEmailOptionSingleFingerprint() as NotReadyForCI
|
Did it. Hoping this will help. |
This PR introduces detection of the armor CRC error with help of new version of PGPainless.
close #1347
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):