issue #1060 pgp decrypt method that mimics error behavior#1216
issue #1060 pgp decrypt method that mimics error behavior#1216
Conversation
tomholub
left a comment
There was a problem hiding this comment.
Thank you - this is what I needed, but needs some improvements. I didn't look at the tests yet (will later).
It seems FORMAT error are not handled? For example, what will happen if I enter "abcd".toByteArray() as the data? It seems like it would throw "OTHER / wrong key" which is not correct.
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
DenBond7
left a comment
There was a problem hiding this comment.
Leaved a few comments. Please look at them.
FlowCrypt/src/main/java/com/flowcrypt/email/extensions/kotlin/ByteArrayExt.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/PgpMsgTest.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/PgpMsgTest.kt
Outdated
Show resolved
Hide resolved
DenBond7
left a comment
There was a problem hiding this comment.
Thank you. Looks good. Approved
|
@tomholub Please review it. I will merge it after your approving |
tomholub
left a comment
There was a problem hiding this comment.
Looks good, with tiny changes, from my end it's good to merge it. I'll let Den do the final review and merging. Thank you!
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/PgpMsgTest.kt
Outdated
Show resolved
Hide resolved
Changed the approving status. I'll approve it after Tom. Due to difficulty of the current issue(decryption process).
|
Ok Den, after the above changes, I'll do my approving review, then you can do yours. |
tomholub
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me. Will let Den take another look and merge it.
This PR introduces 100% jvm based method for the decryption.
close #1060
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):