Issue 1191 display basic msg details#1197
Conversation
| } | ||
| } | ||
|
|
||
| fun InternetAddress.getPersonalElseEmail(): CharSequence { |
There was a problem hiding this comment.
Maybe val InternetAddress.personalOrEmail = get() ...?
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "encryptionType": "STANDARD", | |||
| "inlineSubject": "Standard message - plane text", | |||
There was a problem hiding this comment.
Tiny nitpick - I believe 'plane text' should be 'plain text', if you mean human readable characters, or 'plaintext' if you mean unencrypted text.
If it's intentional then I'm sorry for my misunderstanding, otherwise if it's a misspelling then I can add a commit changing it.
There was a problem hiding this comment.
taking into account file name that is really likely should have been "plain text" or even "plaintext" (as a single word).
There was a problem hiding this comment.
'plaintext' if you mean unencrypted text.
That's what I meant
I can add a commit changing it.
Please don't worry. I will do it myself. Thank you for noticing
seisvelas
left a comment
There was a problem hiding this comment.
Yay! As a user of the Android app, I'm really happy about this functionality being added. I tested this functionality on my phone, here's what it looks like:
Great.
Here's how I'm testing this btw:
export ANDROID_SDK_ROOT=$HOME/Library/Android/sdk
git checkout [whatever branch I'm testing]
./gradlew assembleDebug
adb install FlowCrypt/build/outputs/apk/consumer/debug/FlowCrypt-consumer-debug.apk
Then I just open it in my phone. Which is pretty convenient. Is that the normal, correct way to go about this when I need to manually test the app? Maybe I've been doing it wrong this whole time, lol.
You do all things correctly. I just can recommend you use a little simpler solution export ANDROID_SDK_ROOT=$HOME/Library/Android/sdk
git checkout [whatever branch I'm testing]
- ./gradlew assembleDebug
- adb install FlowCrypt/build/outputs/apk/consumer/debug/FlowCrypt-consumer-debug.apk
+ ./gradlew clean :FlowCrypt:installConsumerDebug |
This PR added displaying basic msg info, added versions support for
flowcrypt-email-serverclose #1191
close #1151
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):