issue #1052 port MsgBlockParser from TypeScript to Kotlin#1079
issue #1052 port MsgBlockParser from TypeScript to Kotlin#1079
Conversation
|
|
|
@tomholub I'm already reviewing it |
|
|
||
| @Test | ||
| fun testDetectBlocksIgnoresFalsePositiveBlocks() { | ||
| checkForSinglePlaintextBlock( |
There was a problem hiding this comment.
Maybe it'll be better to store such a long string as resources. Such code looks bloated and a little hard to read it.
There was a problem hiding this comment.
I think it's ok for unit tests, we do it similarly same in the other repos too.
DenBond7
left a comment
There was a problem hiding this comment.
Looks good to me. The Android side was not affected. Maybe need to move long strings to resources. Anyway, I'm approving it.
|
@tomholub I can see that there are already 2 approvals and all checks have passed, but I can't merge this myself. Please merge this and possibly give me merge permission under condition of having two approvals. |
|
I've set the limit to 1 approval on android repo, and added merge for both Ivan and Den. That means Den can approve and merge Ivan's work. We are moving towards a feature per PR - we used to lump many changes in one PR on this repo because Den worked here alone with my oversight. Now that PRs will be smaller, Ivan can also approve/merge Den's work. The permissions are in place. |
|
Oh - please always squash merge. Let me add that restriction. |
|
@tomholub Thanks! |
// edit tom
close #1052