ask user for account.name when missing during setup

[tomholub]

mindoutofframe@gmail.com

All gmail account should have a name

[DenBond7]

@tomholub Could you provide more details about the current issue? What do I need to fix?

[tomholub]

see 330b181

The name is empty (null), but not sure why

[DenBond7]

For Gmail, we use the info which is provided by the Google API. For example for my test account, it looks like

Maybe for some accounts, this API returns an empty value for googleSign.displayName

[DenBond7]

I've found an explenation

Please look at GoogleSignInAccount class

https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignInAccount.html#public-string-getdisplayname-

Returns the display name of the signed in user if you built your configuration starting from
new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)} or with requestProfile() configured; null otherwise. Not guaranteed to be present for all users, even when configured.

NOT GUARANTEED TO BE PRESENT FOR ALL USERS, EVEN WHEN CONFIGURED.

[tomholub]

Could you in these cases create it from givenName and familyName?

[DenBond7]

But these fields can be null too

[DenBond7]

I think we have to add a field where a user can share a name

[tomholub]

I see. In that case, for now we can skip it, until later. I've prevented the crash by entering an email, which will do for now.