Skip to content

Comments

fix(revert): Revert upgrade flagsmith-flag-engine to v10 (#6653)#6674

Merged
khvn26 merged 5 commits intomainfrom
revert-pr-6653-engine-v10
Feb 10, 2026
Merged

fix(revert): Revert upgrade flagsmith-flag-engine to v10 (#6653)#6674
khvn26 merged 5 commits intomainfrom
revert-pr-6653-engine-v10

Conversation

@gagantrivedi
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Reverts #6653

This PR reverts the flag-engine v10 upgrade, including:

  • Reverting flagsmith-flag-engine from ^10.0.3 back to the fix/missing-export branch
  • Reverting flagsmith SDK from ^5.1.1 back to ^3.10.0
  • Removing pydantic-collections dependency
  • Removing all vendored Pydantic models in util/engine_models/
  • Restoring original imports across the codebase

How did you test this code?

  • CI tests should pass

@gagantrivedi gagantrivedi requested review from a team as code owners February 10, 2026 10:01
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team February 10, 2026 10:01
@cursor
Copy link

cursor bot commented Feb 10, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Feb 10, 2026 0:38am
flagsmith-frontend-preview Ignored Ignored Preview Feb 10, 2026 0:38am
flagsmith-frontend-staging Ignored Ignored Preview Feb 10, 2026 0:38am

Request Review

@gagantrivedi gagantrivedi changed the title revert: feat: upgrade flagsmith-flag-engine to v10 (#6653) fix(revert): feat: upgrade flagsmith-flag-engine to v10 (#6653) Feb 10, 2026
@github-actions github-actions bot added the api Issue related to the REST API label Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6674 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6674 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6674 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6674 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6674 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6674 Finished ✅ Results

@gagantrivedi gagantrivedi changed the title fix(revert): feat: upgrade flagsmith-flag-engine to v10 (#6653) fix(revert): Feat:upgrade flagsmith-flag-engine to v10 (#6653) Feb 10, 2026
@gagantrivedi gagantrivedi changed the title fix(revert): Feat:upgrade flagsmith-flag-engine to v10 (#6653) fix(revert): Feat upgrade flagsmith-flag-engine to v10 (#6653) Feb 10, 2026
@github-actions github-actions bot added the fix label Feb 10, 2026
@matthewelwell matthewelwell changed the title fix(revert): Feat upgrade flagsmith-flag-engine to v10 (#6653) fix(revert): Revert upgrade flagsmith-flag-engine to v10 (#6653) Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (20215d5) to head (5af6124).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6674      +/-   ##
==========================================
- Coverage   98.22%   98.20%   -0.02%     
==========================================
  Files        1313     1298      -15     
  Lines       47481    47172     -309     
==========================================
- Hits        46636    46327     -309     
  Misses        845      845              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added fix and removed fix labels Feb 10, 2026
@github-actions github-actions bot added fix and removed fix labels Feb 10, 2026
@github-actions github-actions bot added fix and removed fix labels Feb 10, 2026
@khvn26 khvn26 requested a review from matthewelwell February 10, 2026 15:18
@khvn26 khvn26 merged commit faa031c into main Feb 10, 2026
33 checks passed
@khvn26 khvn26 deleted the revert-pr-6653-engine-v10 branch February 10, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants