fix(n+1): fix environment-document n+1 for env_feature_version#5332
Merged
gagantrivedi merged 2 commits intomainfrom Apr 11, 2025
Merged
fix(n+1): fix environment-document n+1 for env_feature_version#5332gagantrivedi merged 2 commits intomainfrom
gagantrivedi merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
Docker builds report
|
gagantrivedi
commented
Apr 11, 2025
| "feature", | ||
| "feature_state_value", | ||
| "identity", | ||
| "environment_feature_version", |
Member
Author
There was a problem hiding this comment.
"We can include or exclude this based on whether environment.use_v2_feature_versioning is enabled, but I don't really see any downside to including it for environments where use_v2_feature_versioning is not enabled."
Contributor
|
Uffizzi Preview |
api/tests/unit/environments/test_unit_environments_views_sdk_environment.py
Show resolved
Hide resolved
matthewelwell
approved these changes
Apr 11, 2025
| "feature", | ||
| "feature_state_value", | ||
| "identity", | ||
| "environment_feature_version", |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5332 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 1225 1225
Lines 42551 42556 +5
=======================================
+ Hits 41503 41508 +5
Misses 1048 1048 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewelwell
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Prefetch
environment_feature_versionto avoid n+1How did you test this code?
Unit test updated to cover this change